Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace baroque orchestrator serialize/deserialize code #119

Open
jackjansen opened this issue Oct 15, 2023 · 2 comments
Open

Replace baroque orchestrator serialize/deserialize code #119

jackjansen opened this issue Oct 15, 2023 · 2 comments

Comments

@jackjansen
Copy link
Collaborator

Followup to #117

The current code is a weird set of things that manually decodes and encodes parameters as JSON.

I'm pretty sure that we can have a simple interface where (almost) every call Foo has a FooRequest and FooReply type than are classes that can be jsonified in one step.

There's one or two "funny" calls that are basically unsolicited replies, for example when a new user joins a session.

But I think if we have an orchestrator API that has an interface definition for the outgoing API and an interface definition for the callbacks we're in a situation where it because rather easy to replace the whole orchestrator by something completely different.

@jackjansen
Copy link
Collaborator Author

Other things that need cleanup:

  • converting SessionConfig.ProtocolType by using names like dash internally (same as the string known by the orchestrator).
  • Numeric UserRepresentationType values are ugly.

@jackjansen
Copy link
Collaborator Author

For the numeric values https://code-maze.com/csharp-serialize-enum-to-string/ has some hints.

jackjansen added a commit that referenced this issue Oct 19, 2023
…r records are no longer long-lived in the orchestrator. Does require all participants in the session to have the same definition. Will be fixed with #119.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant