Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several recommendations for the developing of this brilliant work #31

Open
Clancy-wu opened this issue Jan 27, 2023 · 1 comment
Open

Comments

@Clancy-wu
Copy link

Dear Watson,
I learned much from your package and this hepls me a lot, so I should say much thanks to you.
I used to choose GRETNA (a tool for graph theory analysis in matlab, born at year 2013) for my work, but it really out of date for lacking various analysis models.
When I knew about your BrainGraph, I realized that this is what I really want which would meet with all requirements of my work at present. However, I have some suggestions for this version of manual and package, and I hope these points could help you to develp a better future version.

  1. brainGraph User Guide Version 3.0.0 (Page 45, Para 7.2.3 ). I used the .csv connection matrix generated by MRtrix3, so this runs error for my data. After viewedcode sources, I realized that 'matfiles$A' should be the .txt format without quote. I think this point could be provided in the manual.
  2. brainGraph User Guide Version 3.0.0 (Page 46, Para 7.3 ). 'groups=covars.dti$Group' is a mistake. This should be updated to 'grpNames = covars.dti$Group', otherwise it will report error continuously.
  3. For lots of fans of your package, we are the layman in graph theory, so we want to know a little basical informations. eg. Why should I set a series of thresholds, what is recommended for setting this value. A very little explanations would help us a lot. I think kind explanations in the right place could promote the spread of your package.
  4. The most important is, I strongly hope you could publish this work to a journal for the convinient citation of us. I noticed that there still hadn't valid article in your brilliant work. Though I didn't know the reason, I think this could be a pity. At least in my view, I strongly want to citate your work.
    All in all, I hope you could persist in this work and spread the work to more and more people, thus making a hgih citation article.

Best wish,
Yours Sincerely,
Kang Wu

@cwatson
Copy link
Owner

cwatson commented Mar 24, 2023

Sorry for replying so late. I will read through your suggestions and try to implement them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants