Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block support #29

Open
garyjohnson opened this issue Apr 20, 2016 · 1 comment
Open

Block support #29

garyjohnson opened this issue Apr 20, 2016 · 1 comment

Comments

@garyjohnson
Copy link

garyjohnson commented Apr 20, 2016

Thanks for writing this. Wondering if you've considered using block callbacks instead of delegate pattern? It would allow the completion handling code to live near where the alerts are shown instead of being handled in a separate method (that might include a large switch statement if you're showing lots of alerts in a single view). I'd be happy to submit a PR if you're interested in exploring further.

@cwRichardKim
Copy link
Owner

yea absolutely, i'm happy to take a look at any solution you propose. I think it's tough to completely flip the internals now since there are people depending on this project (which has honestly been my major reason for not changing it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants