Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container name and environment variable specification to docker-compose.yaml #99

Open
YoshikiKubotani opened this issue Feb 2, 2024 · 0 comments
Assignees
Labels

Comments

@YoshikiKubotani
Copy link
Collaborator

Why

The current docker-compose.yaml file does not have the name field, leading to the name confliction when multiple containers are booted up. Also, it would be more convenient to have env_file field by default, as it allows to set environment variables by using a .env file.

Definition of Done

  • name filed is added to both cpu/gpu docker-compose.yaml files
  • env_file field is added to both cpu/gpu docker-compose.yaml files
  • A sample environment file envs.env.sample is created under <PROJECT_ROOT>/environment
  • An original environment file envs.env is added to .gitignore

How

Edit docker-compose.yaml files

Note

docker/compose#745 (comment)

@YoshikiKubotani YoshikiKubotani self-assigned this Feb 2, 2024
YoshikiKubotani added a commit to YoshikiKubotani/AscenderTest that referenced this issue Apr 27, 2024
…update-docker-compose-yaml

cvpaperchallenge#99/chore/update docker compose yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant