-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI cache is not used when a new PR is created #81
Comments
@YoshikiKubotani Does this sound reasonable to you? Especially I want to hear your option about my assumption that use of image registry cache it rare case. |
@gatheluck
|
Thank you for your comment!
Yes, but when brand new PR is created, basically there is no cache linked to the branch. So the first time you run CI by new PR, you cannot use cache. I faced this issue multiple times and find this issue report: https://stackoverflow.com/questions/69365200/github-actions-how-to-cache-dependencies-between-workflow-runs-of-different-bra
Unfortunately this is no. Because Cache scopes works first, then inside of the scope cache is searched based on cache key. So "caches belonging to the same branch name" and "caches belonging to the default branch" are only target of cache search. |
Actually I tested these only my forked Ascender branch. When new PR is created first CI run tool long time because there is no cache hit. |
But after adding CI job for default branch it became: |
Sure.
Is my understanding correct? |
As for the image registry cache, I also believe we do not often face the situation of using multiple containers in the research context. |
Thank you! This is correct!
Thank you so much! Then I start working on this ticket. |
Why
In #71, cache for CI is introduced. However, current cache is not used when new PR is created. This is because the current official cache action only able to use "caches belonging to the same branch name" and "caches belonging to the default branch".
At same time currently, image registry cache is not used. This will be useful when multiple containers are used in CI. However it looks rare case. So I'd like to remove image registry cache to same time, and add it to README.md as example.
Definition of Done
How
The text was updated successfully, but these errors were encountered: