Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format for the comments, bundle for vulnerability-lookup #41

Open
adulau opened this issue May 6, 2024 · 4 comments
Open

Format for the comments, bundle for vulnerability-lookup #41

adulau opened this issue May 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@adulau
Copy link
Member

adulau commented May 6, 2024

Vulnerability-lookup will allow logged user (with validated account) and with type "commenter" or "admin" to create comment or bundle.

The format of the JSON foreseen (draft) is the following:

field name values type required description
uuid UUID uuid X UUIDv4 of the message
vulnerability-lookup-origin UUID uuid X UUIDv4 of the vulnerability lookup instance
creation_timestamp datetime datetime X When the message was created originally
timestamp datetime datetime X When the message was last updated
type comment, bundle string X Type of the message. Comment is a title, description text per vulnerability mentioned. Bundle is a bundle of vulnerabilities with title and a description text.
title free text (limit? 65K?) string X Title of the message
description free text string - Description of the message
description-format markdown, text string - Format of the description
vulnerability array of vulnerability references array X One or more vulnerability references for this message
meta array of fields (like MISP galaxy) array - Zero or more meta-fields
@adulau adulau added the enhancement New feature or request label May 6, 2024
@cedricbonhomme
Copy link
Contributor

Thank you for this !

As discussed here I focus on finishing the user management system (creation, management of accounts) with a simple case of submitting a new vulnerability. Just to not have a huge PR. It won't be small PR. But it will be ready soon. I'll make first a draft PR for it.
And after we can add the comments in another PR.

@cedricbonhomme
Copy link
Contributor

cedricbonhomme commented May 6, 2024

And since you raise the problem of 'type' of users, I would like to make clear the different roles we need for the moment.

To summarize, an authenticated user (not an admin) can have several roles/permissions ? For example:

  • commenter (as you said)
  • reporter (to submit/edit vulnerabilities)
    The user can be only commenter, only reporter, or both ? All is fine for me.

Or a same type of authenticated user (not admin) is able to comment and report, without distinction ?

@adulau
Copy link
Member Author

adulau commented May 7, 2024

The roles seen are the following:

  • admin full access to everything including update of other comments or bundles or vulnerabilities
  • commenter allow to create new comment or edit their own comments
  • reporter is also a commenter but can also submit/edit vulnerabilities their own vulnerabilities

@cedricbonhomme
Copy link
Contributor

Thanks for the information. I did the self-creation of accounts (creation by the admin was already done).
The new user receives an email in order to verify the account. When the app is executed in debug mode, the email is simply written in a file. I will update the roles and permissions now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants