Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What format is the output JSON file? Doesn't seem to be Three.js legacy json #204

Open
ericvanular opened this issue Jul 6, 2020 · 5 comments

Comments

@ericvanular
Copy link

ericvanular commented Jul 6, 2020

Would be great to export a standard GLTF file. Are there any plans to support this?

@danilosalvati is there any way to use the JSON file that react-planner outputs in another 3d case? How could I convert it for use in an A-frame scene for example?

@ericvanular
Copy link
Author

@JaccoGoris saw your collada exporter feature. Would you please consider making a GLTF exporter as it seems to be the new standard these days for three js? I'd love to do it myself but not really sure how

@JaccoGoris
Copy link
Contributor

For the record, the JSON export is not 3D data, but just the data of the elements and where they are located in the planner. This data is custom for the react planner. So it is definitely not a sort of GLTF analog.
I can take a look at how you would do a GLTF export, but it will probably require a Three.js update.

@ericvanular
Copy link
Author

Is there a good reason for storing it in a custom way? Wouldn't it be easier to store it in the cross platform GLTF format, which is a JSON standard? It could then integrate with other 3d applications and be a far more useful tool. Please let me know if there's any way to help you, I'm new to WebGL stuff but this is a great project

@ericvanular
Copy link
Author

@JaccoGoris you seem to be the primary maintainer of the project at this point. Your pull requests look great but haven't been merged yet sadly. If the original team has abandoned the project, I would support you taking over (only if you want to and have time of course)

@JaccoGoris
Copy link
Contributor

Hi Eric! the current data json they are using here is just a representation of the scene, to easily build and load the project. I'm not sure if GLTF existed when this project was built, and I'm not sure using GLTF is a good idea, as it is a file format, and it's harder to manipulate the data.
As to your other question, I'll make a fork and continue on that, when I find the time. I also need some changes anyway for project I'm working on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants