Needed Improvements

[ArchBlood]

So after testing out the module I can see some improvements that could be made;

When I tried enabling the module from the marketplace it threw me an error that the resources could not be found, rather weird as I keep my demo updated to the latest changes in the develop branch, so that comes to my other thought which is you're making calls to module classes that aren't installed or enabled, namely the Calendar module, looking deeper I see you make no checks for Yii::$app->hasModule('calendar') which could be the issue;

I've also noticed in the view files there are a few issues;

menu-manager/views/config/_menu-entry-fields.php

Line 9 in 2a383b2

use humhub\modules\menuManager\models\Configuration;use humhub\modules\menuManager\models\MenuEntryConfig;use humhub\modules\ui\form\widgets\ActiveForm;use humhub\modules\ui\form\widgets\IconPicker;use humhub\modules\ui\view\components\View;

menu-manager/views/config/index.php

Line 9 in 2a383b2

use humhub\modules\menuManager\models\Configuration;use humhub\modules\menuManager\Module;use humhub\modules\ui\form\widgets\ActiveForm;use humhub\modules\ui\view\components\View;use humhub\widgets\Button;

Another suggestion would be making the field for "Home" optional or rely on an external module so that it doesn't create another menu item which automatically appends to the "Dashboard", see the screenshot below;

[marc-farre]

@ArchBlood Thanks for your feedback.

1/ See humhub/humhub#6978

2/ Fixed in commit 7385301

3/ I agree, but your screenshot shows a specific configuration where you changed the default Dashboard icon with the "Home" icon. But even is "Dashboard" is the default home page, it's often changed to another page, e.g. a custom page. I prefer to leave it as it is, each one can configure the module the way they want for their usage.

[ArchBlood]

3/ I agree, but your screenshot shows a specific configuration where you changed the default Dashboard icon with the "Home" icon. But even is "Dashboard" is the default home page, it's often changed to another page, e.g. a custom page. I prefer to leave it as it is, each one can configure the module the way they want for their usage.

I've also tested without any configurations with the same being the result;
"Home" is displayed as well as "Dashboard" but both menu items direct to the same place which is the dashboard.

Solution would be making this not visible by all by default.

[marc-farre]

Solution would be making this not visible by all by default.

I thought about it, but it adds complexity in the code and I think it's not bad to show that this module can add a "Home" item. It's only one click to hide it.