Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using webhook auth but still showing no authentication #67

Open
gustafssone opened this issue Nov 20, 2023 · 4 comments
Open

Using webhook auth but still showing no authentication #67

gustafssone opened this issue Nov 20, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@gustafssone
Copy link

gustafssone commented Nov 20, 2023

Hi!

Using the new 0.7.0 version. I have currently a webhook authentication, but it still shows in the settins as "Authorization required: Not required". If I change in Zaptec Portal under authentication to "local/native authentication", the padlock is off (not required).
Shouldn't at least the sensor for Authorization request it is show "webhook auth"?
And/or the Authentication (press start!) be disabled when it is not possible to use it?
I am considering switching to the preferred way of authenticating (available charge current to 0 A), but not there yet.

Thanks for the great work.

Cheers

@sveinse
Copy link
Collaborator

sveinse commented Nov 20, 2023

This is a good idea. I propose adding a new sensor "Authentication Type" which takes on the values "Native", "WebHooks" and "Ocpp" (names fetched from Zaptec). With this it should be possible to disable the buttons that doesn't work unless in native mode.

As for "Authentication required" this value is reported to 0 by zaptec when webhooks or ocpp is selected. Perhaps this is another of the the entities which needs to made unavailable in these two auth modes?

@sveinse sveinse added the enhancement New feature or request label Nov 20, 2023
@gustafssone
Copy link
Author

Good idea with new sensor.
I guess so, yes. In conjunction with Authentication Type it is technically invalid, it is not used. Just saying it can be confusing for some users where they have some other type of authentication but tries to enable it nonetheless.
Also it says Authentication in most places in zaptec portal but "Authorization required" (which I guess is technically correct).

@sveinse
Copy link
Collaborator

sveinse commented Nov 21, 2023

I see both "authentication" and "authorization" in use in Zaptec, and possibly the terms are used correctly. I'll wash through the codebase to see if we use it incorrectly

@sveinse
Copy link
Collaborator

sveinse commented Nov 26, 2023

It certainly is confusing:

  • The installation has an attribute IsRequiredAuthentication
  • The charger has an attribute IsAuthorizationRequired
    I'm really not sure what to land on here, TBH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants