Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the unnecessary wrapping of Option around some return types? #105

Open
flauntingspade4 opened this issue Jan 11, 2021 · 1 comment
Open

Comments

@flauntingspade4
Copy link

I couldn't see a previous issue about it, and there are a few files with unnecessary Option wrappers around their return types, for example here. I can't see if this was used by a previous version, and not updated yet, or if I'm missing something obvious

@flauntingspade4
Copy link
Author

I looked further into it, and it seems that the clippy warnings could be solved, and the code made slightly more consise (But with some extra syntax) by a change like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant