Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the WA Fronted editor plugin #41

Open
1 of 4 tasks
r-a-y opened this issue Oct 25, 2015 · 1 comment
Open
1 of 4 tasks

Support the WA Fronted editor plugin #41

r-a-y opened this issue Oct 25, 2015 · 1 comment

Comments

@r-a-y
Copy link
Member

r-a-y commented Oct 25, 2015

When we started developing Social Paper, only FEE was a viable option for a frontend editor.

WA-Fronted is another frontend editor plugin that has more momentum behind it, appears to be less buggy and is in active development:
https://github.com/jesperbjerke/wa-fronted

It has revision history support, which is on our roadmap and will probably fix many issues that we have with FEE including #10 and #30.

Some of our JS will need to be modified to support WA Fronted. Most notably, the sidebar settings toggle and comment auto-positioning code (see commit 39a83fc).

Marking this as a future release, perhaps as a v2.0.

Notes:

  • WA Fronted does not have a toggle for enabling editing. When you land on your paper page, you can edit immediately.
  • Unlike FEE, saving a post in WA will reload the entire page. As of WA v1.3.0, this is no longer the case.

Todo:

  • Support our custom sidebar from FEE.
  • "New Paper" page needs to be adjusted to work with WA Fronted.
  • Will probably need to add a "Show Comments" toggle since WA doesn't have an 'Enable Editing' button.
  • Stripping the data-incom attribute by Inline Comments will need some work since WA doesn't have a before-save JS hook. (doing this at the server level for now - see commit 9b66cb5)
r-a-y added a commit that referenced this issue Oct 25, 2015
Comment auto-repositioning code adjusted to work with both WA Fronted
and FEE.

See #41.
r-a-y added a commit that referenced this issue Oct 25, 2015
r-a-y added a commit that referenced this issue Oct 25, 2015
We're stripping the 'data-incom' attribute at the server level to fix
issues with WA Fronted.

See #41.
@boonebgorges
Copy link
Member

This looks really promising - thanks, @r-a-y!

One lame side note is that the plugin requires PHP 5.4.3, a requirement
we don't meet on the Commons production server. We (desparately) need to
upgrade anyway, so maybe it's no big deal, but it's one more thing to do.

On 10/25/15 15:05, r-a-y wrote:

When we started developing Social Paper, only FEE was a viable option.

WA-Fronted is another frontend editor plugin that has more momentum
behind it, appears to be less buggy and is in active development:
https://github.com/jesperbjerke/wa-fronted

It has revision history support, which is on our roadmap and will
probably fix many issues that we have with FEE including #30
#30.

Some of our JS will need to be modified to support WA Fronted. Most
notably, the sidebar settings toggle and comment auto-positioning code.

Marking this as a future release, perhaps as a v2.0 or v1.1.


Reply to this email directly or view it on GitHub
#41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants