Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: geonames extractor problems with admin hierarchy #37

Open
gklyne opened this issue Jul 10, 2019 · 0 comments
Open

BUG: geonames extractor problems with admin hierarchy #37

gklyne opened this issue Jul 10, 2019 · 0 comments

Comments

@gklyne
Copy link
Contributor

gklyne commented Jul 10, 2019

I just noticed a problem with some data generated by the geonames extractor/converter.

E.g., see: https://github.com/culturesofknowledge/emplaces/blob/master/src/geonamesdataexport/data-20190624/geonames-data-ref-by-EMLO-0001-0100.ttl#L20467

The em:hasRelation showing Friesland_ADM1_2755812_geonames as part of Netherlands_PCLI_2750405_geonames has an incorrect value for em:relationType at line 20496: it is recorded as em:P_PART_OF_A, but should be em:A_PART_OF_A.

At the time of writing, I don't know if this is throughout the data - I suspect it is: I may have failed to take account of the type of the place for which the relation is described.

Code for this is at about:

https://github.com/culturesofknowledge/emplaces/blob/master/src/geonamesdataexport/get_geonames_data.py#L865

It does appear that the relationship type is hard-wired, rather than being derived based on the place type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant