Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modules: add tests to ensure that we use older semantics even when publishing using newer language version #3128

Closed
myitcv opened this issue May 8, 2024 · 1 comment
Closed

modules: add tests to ensure that we use older semantics even when publishing using newer language version #3128

myitcv opened this issue May 8, 2024 · 1 comment
Assignees
@rogpeppe
Labels
FeatureRequest New feature or request modules Issues related to CUE modules and the experimental implementation

Comments

@myitcv
Copy link
Member

myitcv commented May 8, 2024 •
edited

For example when publishing a module that declares:

module: "github.com/example/pkg

language: version: "v0.9.0"

Say the user is using v0.10.0 (this has not yet been released but just imagine it has).

We need to ensure that the v0.9.0 semantics for cue.mod/module.cue are using, despite the fact the user is using v0.10.0.
@myitcv myitcv added FeatureRequest New feature or request modules Issues related to CUE modules and the experimental implementation labels May 8, 2024
@rogpeppe rogpeppe changed the title modules: add tests to ensure that we use the v0.9.0 semantics even when publishing using v0.10.0 modules: add tests to ensure that we use older semantics even when publishing using newer language version May 14, 2024
@myitcv
Copy link
Member Author

myitcv commented May 14, 2024

Discussed with @rogpeppe we think we have good coverage here for now. We can create issues if we spot any problems.

@myitcv myitcv closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogpeppe rogpeppe

Labels
FeatureRequest New feature or request modules Issues related to CUE modules and the experimental implementation
Projects
Modules Roadmap
Status: Done
Release v0.9
Status: v0.9.0-alpha.5
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rogpeppe @myitcv