Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime.getSupportCodeLibrary returns a new instance #603

Closed
fpanwaskar opened this issue Jul 4, 2016 · 3 comments
Closed

Runtime.getSupportCodeLibrary returns a new instance #603

fpanwaskar opened this issue Jul 4, 2016 · 3 comments

Comments

@fpanwaskar
Copy link

Requirement:
We are implementing a wrapper around cucumberjs to speedup the testing process across the company. We have a requirement to allow for step definitions to call other step definitions as discussed here. To support this we are dynamically adding new steps before the feature runs using the support code library defineStep(...).

Issue:
The runtime offers access to the support code library retrieving it from the configuration. But each time it it is retrieved a new instance is returned.

I would expect this to be tied to the runtime instance so once it is retrieved we return the same instance.

Please let me know if this seems reasonable, I'm happy to make the change and test it.

@charlierudolph
Copy link
Member

Sorry for the delay @fpanwaskar. This change sounds good to me. If you could make the changes with some tests that would be great!

@charlierudolph
Copy link
Member

In 2.0.0-rc.1 the method in question was removed.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants