Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci tooling change? #1513

Closed
davidjgoss opened this issue Dec 18, 2020 · 7 comments · Fixed by #1518
Closed

ci tooling change? #1513

davidjgoss opened this issue Dec 18, 2020 · 7 comments · Fixed by #1518
Assignees
Labels
🔧 build Related to build / release process

Comments

@davidjgoss
Copy link
Contributor

See:

Travis is looking like slightly shaky ground now.

Is it worth giving GitHub Actions a try?

cc @charlierudolph @aslakhellesoy

@davidjgoss davidjgoss added the 🔧 build Related to build / release process label Dec 18, 2020
@aslakhellesoy
Copy link
Contributor

Yes - let’s move to GitHub Actions. We discussed this in the weekly meeting on 10th dec too

@davidjgoss davidjgoss self-assigned this Dec 21, 2020
@davidjgoss
Copy link
Contributor Author

Okay, we have a workflow in now that tests with our supported Node versions on Linux and Windows. That covers most of what we were doing with Travis and Appveyor.

The only other thing is coverage. Right now we run with coverage on Node 14 but don't seem to do anything with the result.

@davidjgoss
Copy link
Contributor Author

davidjgoss commented Dec 21, 2020

I see https://coveralls.io/ used a lot in other open source projects. Would be a nice way to get it visible in the PR.

@davidjgoss
Copy link
Contributor Author

@charlierudolph how do you feel about adding coveralls?

@charlierudolph
Copy link
Member

Coverage is currently sent to coveralls but not reported on PRs. I'm good with adding coveralls and getting visibility for it on PRs

@charlierudolph
Copy link
Member

Thanks for doing this @davidjgoss. I just disabled the appveyor project so that should stop triggering builds

@aslakhellesoy
Copy link
Contributor

Thanks a lot for doing this @davidjgoss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 build Related to build / release process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants