Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to redux store in withJobs` work #48

Open
oyeanuj opened this issue Nov 29, 2017 · 3 comments
Open

Access to redux store in withJobs` work #48

oyeanuj opened this issue Nov 29, 2017 · 3 comments

Comments

@oyeanuj
Copy link

oyeanuj commented Nov 29, 2017

Hi @ctrlplusb! Firstly, thanks as always for putting out these super useful libraries.

For my usecase, I am using it with Redux and a common usecase for that is to to check if the data in question is already in the store or not. To do that, one needs access to the store, which currently is not passed on by withJob to work.

For my own work, I just manually added that to the context, and passed it through but what are your thoughts on a more standard solution for such cases? I know you've previously talked about an abstraction like redux-jobs but I imagine that too would need this piece of information.

Thoughts?

@ctrlplusb
Copy link
Owner

Hey @oyeanuj

I would have imagined a wrapper component of sorts. I'll have to spike out an example on codesandbox.io. But it would be great to be able to leave react-jobs as is and simply compose over it.

@moiz-frost
Copy link

Any example yet?

@moiz-frost
Copy link

@ctrlplusb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants