Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check signalp dependency and dockerize BACTpipe #161

Merged
merged 5 commits into from
Apr 16, 2021
Merged

Check signalp dependency and dockerize BACTpipe #161

merged 5 commits into from
Apr 16, 2021

Conversation

abhi18av
Copy link
Collaborator

@abhi18av abhi18av commented Feb 21, 2021 •
edited

This PR addresses

  • Docker based execution
  • Fix the stub
  • Renaming the prokka variable
  • Checking for signalp dependency

@abhi18av abhi18av self-assigned this Feb 21, 2021
@abhi18av abhi18av linked an issue Feb 21, 2021 that may be closed by this pull request
Warn user if signalp is missing if prokka_gram is true #148
Open
@abhi18av abhi18av linked an issue Feb 21, 2021 that may be closed by this pull request
Containerization using Docker #47
Closed
@abhi18av abhi18av changed the title Check signalp dependency Check signalp dependency and dockerize BACTpipe Feb 22, 2021
@abhi18av abhi18av linked an issue Feb 23, 2021 that may be closed by this pull request
Make the pipeline tower friendly and update docs with the instructions #126
Open
@boulund boulund merged commit 8cbd0e0 into develop Apr 16, 2021
@abhi18av abhi18av mentioned this pull request Apr 16, 2021
Merged
@abhi18av abhi18av deleted the abhinav/check_signalp branch May 4, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulund boulund boulund left review comments

Assignees

@abhi18av abhi18av

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@abhi18av @boulund