Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it seems that there are some preblems in the pytorch implement of this code! #75

Open
cscss opened this issue Dec 19, 2019 · 3 comments

Comments

@cscss
Copy link

cscss commented Dec 19, 2019

Hi, Thanks for release the code. I have read your code. It's brilliant!
but I found a small problem in your pytorch code.
when get patches. you data augment have some problems about cv2.imresize. you can check you codes in ./DnCNN-master/TrainingCodes/dncnn_pytorch/data_generator.py line 94.

@oneTaken
Copy link

oneTaken commented Jan 3, 2020

What's the problem?

@cscss
Copy link
Author

cscss commented Jan 3, 2020

When you use opencv to bicubic, the size of image should be (w,h), not (h, w). It is just a small problem, but it could be error when run this code.

@oneTaken
Copy link

oneTaken commented Jan 3, 2020

Yeah, you're right.
It's really a small code bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants