Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying rootDir with linked module breaks css-modulesify #84

Open
troyastorino opened this issue Feb 16, 2016 · 0 comments
Open

Specifying rootDir with linked module breaks css-modulesify #84

troyastorino opened this issue Feb 16, 2016 · 0 comments

Comments

@troyastorino
Copy link

In a project, I have some components stored in separate modules, and the main module installs those modules in using npm link (i.e., creating symlinks to them from node_modules). The structure looks like this:

project
  main
    package.json
    node_modules
      componentA -> ../../componentA
      componentB -> ../../componentB
  componentA
    package.json
  componentB
    package.json

main, componentA and componentB all use CSS Modules. I'm running browserify from of the main module, and have css-modulesify configured with global: true

I ran into problems with css-modulesify constructing paths to filenames in componentA and componentB incorrectly. I ultimately traced this down to the rootDir option. Originally, I had rootDir set to /path/to/project/main, since I thought rootDir only controlled formatting of generated classnames. Setting rootDir to /path/to/project fixed the issues.

Is it the intended behavior for rootDir to cause css-modulesify to fail if there are any css files that are relatively 'higher' that rootDir? If it is, I think it would probably be good to change the documentation in the README to be something like:

  • rootDir: absolute path to your project's root directory. This is optional but providing it will result in better generated classnames. If provided, attempting to bundle any css files accessed via a parent of rootDir will fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant