Skip to content
This repository has been archived by the owner on May 4, 2023. It is now read-only.

Setting new parameters does not affect the current session #28

Open
tsieger opened this issue Jan 13, 2017 · 2 comments
Open

Setting new parameters does not affect the current session #28

tsieger opened this issue Jan 13, 2017 · 2 comments

Comments

@tsieger
Copy link
Contributor

tsieger commented Jan 13, 2017

When setting new parameters using the Set parameters button, the new parameters do not take immediate effect, but apparently take effect after new data loading.
It would be nice if some parameters, e.g. the parameters controlling the "force membership" feature (e.g. par.template_sdnum) or plotting parameters (e.g. par.to_plot_std or par.max_spikes_plot) could be set on the fly, such that the user could immediately see their effects for the clusters identified currently, without a need to reload the signal and re-apply operations leading to the given clusters.

@ferchaure
Copy link
Member

You are right. At the beginning we did that because that was an easy way to implement the behaviour of the button (in the old wave_clus that button was useless). The idea was make a nice GUI like a form for that, with some fields disable for each type of file; because, if you load a spikes or times the GUI will take the parameters inside them (detection and clustering parameters respectively).

But, we had a few problems with the implementation:

  • Change the force parameters and fix classes could generate classes with different types of forced assignments and reduce the reproducibility of the sorting.
  • We are trying to continue the style of the first wave_clus and keep the GUI as simple as possible
  • It require to change quite a lot of code and we need time for that.

However, I will try to work around this issue (at least for the plotting related parameters)

@ferchaure
Copy link
Member

I added a line in the top of the "set parameters windows" explaining this behaviour

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants