Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources for invalid courses causes error #373

Open
smartspot2 opened this issue Jan 15, 2023 · 0 comments
Open

Resources for invalid courses causes error #373

smartspot2 opened this issue Jan 15, 2023 · 0 comments
Labels
bug Something isn't working sev4 Normal severity - System impaired

Comments

@smartspot2
Copy link
Member

After the valid_until date passes for a course, it is no longer given as a part of the /api/courses query (it is excluded from the queryset), but the resources seem to still be accessible. This causes some weird behavior on the resources page, and can occasionally cause errors if no course is valid.

Some options:

  • Keep displaying course resources for courses past their valid_until date, but also keep the current behavior of removing them from the course menu, etc.
  • Remove course resources entirely from requests past their valid_until date, just like how we exclude courses from the course views.
  • Change the behavior of requests for courses, and instead always give all courses present in the database, even if they're past their valid_until date. This would mean that the valid_until date is purely for attendances, and not for display or any requests for data.
@smartspot2 smartspot2 added the bug Something isn't working label Jan 15, 2023
@smartspot2 smartspot2 added the sev4 Normal severity - System impaired label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sev4 Normal severity - System impaired
Projects
None yet
Development

No branches or pull requests

1 participant