Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Watermark upscaling #397

Open
jvahldick opened this issue Oct 2, 2023 · 0 comments
Open

Question: Watermark upscaling #397

jvahldick opened this issue Oct 2, 2023 · 0 comments

Comments

@jvahldick
Copy link
Contributor

jvahldick commented Oct 2, 2023 •
edited

Hey there,

I noticed that these two lines of the watermark filter have been using SizeDown.
https://github.com/cshum/imagor/blob/v1.4.7/vips/filter.go#L51
https://github.com/cshum/imagor/blob/v1.4.7/vips/filter.go#L57

Is there any specific reason to use it instead SizeBoth?
At least from some tests I've done using SizeBoth, it works well there in case the base image is bigger than the max size of the watermark image.
@jvahldick jvahldick changed the title Question: Watermark Question: Watermark upscaling Oct 2, 2023
@jvahldick jvahldick mentioned this issue Oct 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jvahldick