-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically not applying SRGB profile on webp conversion #324
Comments
@mevinbabuc would you test the docker build under master branch?
|
I see that the WebP issue is resolved. Awesome but when explicitly setting to JPEG I face the same issue Is it expected? |
Setting JPEG explicitly should be no problem. |
We have been stripping ICC profiles in production.
Above, we are converting the same image to Webp, by stripping ICC But when switching the format explicitly to JPEG, when IMAGOR_AUTO_WEBP is true Maybe in webp, color profiles are actually not getting stripped? |
I tried adding a Does you code base added some other processing under the sharp pipeline? |
@cshum, this is how our sharp pipeline looks like
Hope this is helpful. |
@cshum Upon looking into your commit, I'm not able to find the mapping for It would really help us out if you could take a second look at this, as few photographers have started to switch more into using ProPhoto RGB. |
Other libraries may have been swapping a more lightweight ICC profile instead of stripping it completely. Will need a more detailed look. |
Maybe @lovell who created the sharp library can shed some light on how they handle color profile conversions. As this is geared towards web usage, we would like ProRGB or AdobeRGB or any other color profiles to be explicitly converted to sRGB for web use. |
Use https://www.libvips.org/API/current/libvips-colour.html#vips-icc-transform I suspect you'll also want to test with CMYK images, both with and without profiles. |
@cshum Hi, do you have the bandwidth to take a look at the suggestion by lovell ? |
@mevinbabuc I was trying to apply similar logic some time ago, but no luck so far with the said image b8a75af#diff-e488e36196c25a401a5af66dd4e6010e8b4e2dec77d4eaba2b6c66fe86a3933bR503 |
@mevinbabuc can you share the image generated? |
Few images that don't have a color profile attached with it, comes out as dull images. This is happening only with WEBP outputs. JPEG is fine.
We have temporarily switched to sharp, which is able to handle this.
I tried this with your latest release.
This is the image
https://s3-ap-southeast-1.amazonaws.com/asia-compressed-image-store/aJu2ijdgnZXpBPds-0UXUxiXcJUOqaUVh-JHUAwEiznuzXHxyy-b'QVJKMDQ5MDQtRWRpdC5qcGc='.jpg
Converting the above image to webp using imagor gives a dull output.
settings that I have:
@cshum Any pointers in the right direction would be helpful.
The text was updated successfully, but these errors were encountered: