From e961fa19f22e2376b0c8a167ebe088fb396ec3f3 Mon Sep 17 00:00:00 2001 From: Christopher Schleiden Date: Sun, 21 Jan 2024 04:02:10 +0000 Subject: [PATCH] Remove remaining panics --- internal/worker/workflow.go | 2 +- internal/workflow/executor.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/worker/workflow.go b/internal/worker/workflow.go index 7b457e22..e048aa23 100644 --- a/internal/worker/workflow.go +++ b/internal/worker/workflow.go @@ -78,7 +78,7 @@ func (wtw *WorkflowTaskWorker) Complete(ctx context.Context, result *workflow.Ex if err := wtw.backend.CompleteWorkflowTask( ctx, t, t.WorkflowInstance, state, result.Executed, result.ActivityEvents, result.TimerEvents, result.WorkflowEvents); err != nil { wtw.logger.ErrorContext(ctx, "could not complete workflow task", "error", err) - panic("could not complete workflow task") + return fmt.Errorf("completing workflow task: %w", err) } return nil diff --git a/internal/workflow/executor.go b/internal/workflow/executor.go index 24bcd431..3bfac035 100644 --- a/internal/workflow/executor.go +++ b/internal/workflow/executor.go @@ -245,7 +245,7 @@ func (e *executor) replayHistory(h []*history.Event) error { for _, event := range h { if event.SequenceID < e.lastSequenceID { e.logger.Error("history has older events than current state") - panic("history has older events than current state") + return errors.New("history has older events than current state") } if err := e.executeEvent(event); err != nil {