Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API change: rename sons/father to next/predecessor in nodes #2398

Open
montyly opened this issue Apr 4, 2024 · 0 comments
Open

API change: rename sons/father to next/predecessor in nodes #2398

montyly opened this issue Apr 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@montyly
Copy link
Member

montyly commented Apr 4, 2024 •
edited

I think next/predecessor will be more intuitive than sons/father for the CFG (https://github.com/crytic/slither/blob/master/slither/core/cfg/node.py)

This will be a breaking change, but most likely not too many external code relies on this.

I would in favor to keep in parallel keep sons and fathers for a few iteration but making it clear that they are deprecated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@montyly @0xalpharush