Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current version #129

Open
pyrsmk opened this issue Apr 15, 2021 · 13 comments
Open

Current version #129

pyrsmk opened this issue Apr 15, 2021 · 13 comments
Labels

Comments

@pyrsmk
Copy link

pyrsmk commented Apr 15, 2021

Currently, we're still at the 0.8.0 version even if there have been several new commits. What is the current state of ICR? Is it compatible with Crystal 1.0 yet?

Cheers!

@jwoertink
Copy link
Collaborator

There's 1 more PR I'd like to get in before we cut another release. I haven't actually tested to see if it works with Crystal 1.0 yet, but after this last PR gets merged in, we will give it a shot and release the next version.

@pyrsmk
Copy link
Author

pyrsmk commented Apr 15, 2021

Glad to hear it! ICR is a must-have in the Crystal developer toolbelt 😎

@jwoertink
Copy link
Collaborator

That's good you're digging it. I will confess that I don't use ICR anymore. With Lucky, we have a built-in way of running some arbitrary Crystal code, so between that, and using the Crystal playground, there's not much need for ICR. I will, however, continue to review and merge PRs and cut new releases when the community contributes. I just won't be working on bug fixes or new features myself.

If you're using it quite a bit, and you (or anyone else reading this) see some issues you'd like to see fixed, please feel free to send in some PRs! Every little bit helps 😄

@pyrsmk
Copy link
Author

pyrsmk commented Apr 15, 2021

I understand! ICR is especially handy when we need to focus on the terminal. But Crystal play is doing a good job too.

In all cases, I'll be glad to help whenever I can. Since I'm developping several professionnal projects in Crystal, it could come sooner than expected 😅

@mationai
Copy link

Any update? An offline icr is needed for those not using lucky.

@jwoertink
Copy link
Collaborator

Hey, thanks for the ping @fuzzthink. I meant to come back and check in on this, and time got away from me. I'm looking it over now, and see where we're at.

@jwoertink
Copy link
Collaborator

Ok, looks like we need to get readline updated crystal-lang/crystal-readline#4 I've submitted the PR, but once that's merged in, then ICR should work fine. I can do a patch release though because I think there's a few small updates. The last PR I was waiting on doesn't seem to be ready just yet, so we can handle that once it's good to go.

@mationai
Copy link

@jwoertink Thank you! Yes, readline is error-ing saying it needs crystal >= 0.31.1 while I have 1.0.0.

@pyrsmk
Copy link
Author

pyrsmk commented Sep 25, 2021

@jwoertink So... It has been merged 😋😘

Anyway, it seems that ICR is not compatible with OptionParser anymore 🤔 And maybe there are some other incompatibility issues too. I'm running Crystal 1.1 btw. If you don't have time, I probably could try to push a PR to make ICR compatible with it.

@jwoertink
Copy link
Collaborator

Yeah, I was hoping this PR #128 could make it in. I'll take a look at getting it all up to date. I have a few minutes.

On a side note, I'm not sure how others feel, but my guess is that once the interpreter is merged crystal-lang/crystal#11159 then this shard will basically be moot and probably archived. So I'd expect that the development of this may probably slow down.

@jwoertink
Copy link
Collaborator

ok, I just tried master branch from a fresh clone and install, and it all seems fine... @pyrsmk did you get any specific error related to OptionParser?

image

@pyrsmk
Copy link
Author

pyrsmk commented Sep 26, 2021

Yeah, I was hoping this PR #128 could make it in. I'll take a look at getting it all up to date. I have a few minutes.

On a side note, I'm not sure how others feel, but my guess is that once the interpreter is merged crystal-lang/crystal#11159 then this shard will basically be moot and probably archived. So I'd expect that the development of this may probably slow down.

I didn't know about that. I agree that when the integrated interpreter is merged, icr can be archived then. According to what the crystal's interpreter does compared to ICR, obviously.

ok, I just tried master branch from a fresh clone and install, and it all seems fine... @pyrsmk did you get any specific error related to OptionParser?

My bad, I didn't give context. It happens when building ICR:

❯ cd lib/icr/; make build
/usr/bin/shards build
Dependencies are satisfied
Building: icr
Error target icr failed to compile:
Showing last frame. Use --error-trace for full trace.

In src/icr/cli.cr:69:14

 69 | OptionParser.parse! do |parser|
                   ^-----
Error: undefined method 'parse!' for OptionParser.class

make: *** [Makefile:7: build] Error 1

@jwoertink
Copy link
Collaborator

Ah. Ok, you must not be pulling from the master branch then. I've released 0.9.0 now. Give that a shot, and you should be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants