Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xattr for Winfsp #87

Open
infeo opened this issue Nov 24, 2023 · 2 comments
Open

Enable xattr for Winfsp #87

infeo opened this issue Nov 24, 2023 · 2 comments
Milestone

Comments

@infeo
Copy link
Member

infeo commented Nov 24, 2023

Due to #86, we had to deactivate extended attributes for Windows. It is desirable to activate again, but it depends on winfsp/winfsp#531.

@infeo
Copy link
Member Author

infeo commented Dec 5, 2023

We could do a similar approach as for getxattr:

if (xattr.list().stream().noneMatch(key -> key.equals(name))) {
return switch (OS.current()) {
case MAC -> -errno.enoattr();
default -> -errno.enodata();
};
}

@infeo
Copy link
Member Author

infeo commented Dec 7, 2023

A different approach: Precheck the underlying filesystem for userdefined attribute view via FilesystemProvider::supportedAttributeViews and adjust the set of supported operations accordingly!

We would loose flexibility, if the underlying filesystem suddenly activates the userDefinedAttributeView.

@infeo infeo added this to the 4.1.0 milestone Dec 8, 2023
@infeo infeo modified the milestones: 5.0.0, 5.1.0 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant