New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLite queries return stale table metadata after alter operation #529

Open

2 tasks done

JaniruTEC opened this issue Apr 10, 2024 · 0 comments

Open

2 tasks done

SQLite queries return stale table metadata after alter operation #529

JaniruTEC opened this issue Apr 10, 2024 · 0 comments

Labels

type:bug

Contributor

JaniruTEC commented Apr 10, 2024 •

edited

Please agree to the following

I have searched existing issues for duplicates
I agree to follow this project's Code of Conduct

Summary

In rare cases queries to a recently changed table will return stale table metadata (e.g. column names). This might cause difficult to diagnose bugs during database migration. So far this issue hasn't been reported in production, but was encountered during development on #506.

System Setup

...

Cloud Type

No response

Steps to Reproduce

...

Expected Behavior

...

Actual Behavior

...

Reproducibility

Always

Relevant Log Output

No response

Anything else?

Related bug on the google issue tracker: 153521693

JaniruTEC added the type:bug label

JaniruTEC changed the title ~~SQLite queries return stale table metadata after update~~ SQLite queries return stale table metadata after alter operation

JaniruTEC added a commit that referenced this issue


          Added tests for migration to v13

c13b12f

UpgradeDatabaseTest.kt:816 and UpgradeDatabaseTest.kt:895 caused the tests to fail because of issue #529 [1]. Consequently they have been commented out until the issue is resolved.

[1] #529

JaniruTEC added a commit that referenced this issue


          Added tests/snippets to explain/reproduce bug #529 [1]

267b20b

Copied from the Android-Issue-153521693 project [2]

*This commit is related to issue #529 [1]*

[1] #529
[2] https://github.com/SailReal/Android-Issue-153521693/tree/cfb5033cf287572ac4b4972700f1656ce2b61d03/src/androidTest/java/de/skymatic/android_issue153521693

JaniruTEC added a commit that referenced this issue


          Applied code style to BugTest.kt and SmallBugTest.kt

eb02fc0

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Finalized work on BugTest.kt and SmallBugTest.kt

7b78b92

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Specified journal mode

95f65c3

Room is designed to choose the journal mode itself if none is specified.
greenDAO's journal mode ("TRUNCATE") will stay for now because the journal mode has influence on the behavior caused by issue #529 [1] and because changing the journal mode complicates the migration further.
This can still be changed later.

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Added first implementation of "CacheControlledSupportSQLiteDatabase"

ff67959

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Refactored "CacheControlledSupportSQLiteDatabase"

1afa7b7

Replaced particular implementation of "fix" with call to freshly introduced, user-supplied mapping function (and added "RandomUUIDSQLMappingFunction" as new mapping function with that particular implementation)
Replaced "fixCompile" with direct instantiation of "CacheControlledSupportSQLiteStatement"
Updated static elements to be inner members of "CacheControlledSupportSQLiteDatabase" (and removed now unnecessary properties)
Changed computation logic of "sql" property in "CacheControlledSupportSQLiteQuery"

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Narrowed visibility for members of "AOP_SQLiteDatabase" class

7d5de82

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Renamed parts of cache-control

13261d6

Renamed package "org.cryptomator.data.db.cachecontrol" to "org.cryptomator.data.db.sqlmapping"
Renamed "CacheControlledSupportSQLiteDatabase.kt" to "MappingSupportSQLiteDatabase.kt"
Moved contents to new location

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Renamed class "CacheControlledSupportSQLiteDatabase" and its members

42f572a

Renamed class "CacheControlledSupportSQLiteDatabase" to "MappingSupportSQLiteDatabase"
Renamed class "CacheControlledSupportSQLiteOpenHelper" to "MappingSupportSQLiteOpenHelper"
Renamed class "CacheControlledSupportSQLiteOpenHelperFactory" to "MappingSupportSQLiteOpenHelperFactory"
Renamed inner class "CacheControlledSupportSQLiteStatement" to "MappingSupportSQLiteStatement"
Renamed inner class "CacheControlledSupportSQLiteQuery" to "MappingSupportSQLiteQuery"
Renamed method "fix" to "map" in "MappingSupportSQLiteDatabase"
Renamed method "fixWhereClause" to "mapWhereClause" in "MappingSupportSQLiteDatabase"
Renamed property "identifiers" to "mappedQueries" in "MappingSupportSQLiteQuery"
Renamed extension method "SupportSQLiteOpenHelper.Factory.asCacheControlled" to "SupportSQLiteOpenHelper.Factory.asMapped" in "MappingSupportSQLiteDatabase.kt"

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Reorganized cache-control to improve abstraction

db2edda

Moved "RandomUUIDSQLMappingFunction" from "MappingSupportSQLiteDatabase.kt" to new file "SQLiteCacheControl.kt"
Added extension function "SupportSQLiteOpenHelper.Factory.asCacheControlled" in "SQLiteCacheControl.kt" as wrapper for "asMapped" with "RandomUUIDSQLMappingFunction" as mapping function
Removed "RandomUUIDSQLMappingFunction" as default mapping function from extension function "SupportSQLiteOpenHelper.Factory.asMapped" in "MappingSupportSQLiteDatabase.kt"
Replaced call to "asMapped" with call to "asCacheControlled" in "DatabaseModule"

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Renamed "RandomUUIDSQLMappingFunction" to "RandomUUIDMapping"

eae6c03

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Refactored "SQLMappingFunction"

35b4e00

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Redefined logic of "MappingSupportSQLiteQuery"

95eede5

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Re-enabled tests

b3449f0

See: c13b12f

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Added first tests for "MappingSupportSQLiteDatabase"

6b1a9b5

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Added support for mapping cursors

af17db5

Calling "requery" on a cursor may cause the driver to re-use queries, which is unwanted behavior.

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Renamed "DataForTestQueryCancelable"

34f75af

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Extracted methods "cartesianProduct" and "toArgumentsStream"

ed0fe82

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Added test for "update"

c89f4b1

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Specified contract for "SupportSQLiteDatabase.insert"

d98ce8b

Also moved compat method for "ContentValues.isEmpty"

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Added tests for "insert"

bfcca43

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Refactored "Sql" to follow the API contract of "SupportSQLiteDatabase"

6af9811

This also makes the class compatible with "MappingSupportSQLiteDatabase"

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Fixed "migrate12To14IndexSideEffects"

abf19e2

This also makes the test method compatible with "MappingSupportSQLiteDatabase"
Also added "assertIsUUID"

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Applied fix for #529 [1] to re-enabled tests

0e63cad

See: b3449f0
Also See: c13b12f

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Moved logic for handling extra calls to dedicated class "OneOffDelegate"

9f70454

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Implemented "MappingSupportSQLiteQuery.bindTo" with "OneOffDelegate"

b691766

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Added "ValueExtractor" as argument type of "pseudo equality" methods

77fa76f

Added "ValueExtractor<T>" as type alias for "(T) -> Any?"
Changed argument declarations of "pseudo equality" methods and underlying implementations
Added "ValueExtractor<T>" as type declaration for existing value extractor sets

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Enforced single call convention for parts of "MappingSupportSQLiteQuery"

cfde324

Also added workaround for tests

*This commit is related to issue #529 [1]*

[1] #529

JaniruTEC added a commit that referenced this issue


          Refactored "insert" and "compileStatement"

40a4ed5

Changed "insert" to directly compile the mapped sql instead of creating a "MappingSupportSQLiteStatement"
Added check if the database is open to "compileStatement"

*This commit is related to issue #529 [1]*

[1] #529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment