Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember already uploaded files to not auto-upload them again if cloud files are moved #448

Open
2 tasks done
cy2201 opened this issue May 26, 2022 · 4 comments
Open
2 tasks done
Labels
type:feature-request New feature or request

Comments

@cy2201
Copy link

cy2201 commented May 26, 2022

Please agree to the following

Summary

Implement a protocol about already uploaded files to avoid reuploading them with auto-upload

Motivation

I use Cryptomator everyday. All photos and videos are uploaded automatically and immediately. I have different types of media files on my smartphone: self created with the camera app, downloaded from somewhere or received from WhatsApp & co. and that's how I sort the files from time to time in the cloud (from my PC). I create a lot subfolders in the Crypto-Cloud and move the files into them. The problem is the Cryptomator app thinks these moved (or deleted) files were never uploaded and begins the auto upload of thousands files after re-unlocking the vault. That's very annoying. Cryptomator should "remember" (in a database) which files are already uploaded even if they are deleted / moved in the cloud.

This function should be configurable in the settings like "Default - like now and upload everything again" or "Do not upload files that have been previously uploaded".

I think the implementation of this feature request is relative easy. I would implement a SQLite database where all once uploaded files are stored into it and just check the settings. If the user set "Don't reupload once uploaded files" then compare all files with the database entries before auto-uploading them (again).

Considered Alternatives

Or save the information about previously uploaded files in a text file inside the vault. Maybe a simple checksum of the files and the last modification date are enough to check if a file was previously uploaded.

Anything else?

No response

@cy2201 cy2201 added the type:feature-request New feature or request label May 26, 2022
@f-m-1979
Copy link

f-m-1979 commented Jan 4, 2023

Hi,

i do have exactly the same requirement.
From time to time I move uploaded photos from the cloud in another directory, and after that Cryptomator (Android) uploads them again from the phone.

As i was searching for this topic, i found a comment from 2019 from @SailReal that this should already work but in some cases ít does not, because the operation system on the phone wrongly tells Cryptomator that there are new files

https://community.cryptomator.org/t/automatischer-foto-upload/3814/30

br,
Franz

@HugoNext
Copy link

HugoNext commented Jan 6, 2023

Hello all,

I have exactly the same problem.
My environment: Android 13 on a Google Pixel 6.
Cryptomator in version 1.7.5.

When moving images in the vault or moving from the vault to another vault via the desktop, all images are automatically re-uploaded.
At the moment I try to stop the autoupload. Then I take out or move the images via the desktop. Then I delete the cache of Cryptomator on the Android device and reactivate the autoupload. Then it works.
Would be good if there would be a solution for this.

Thanks a lot!

@HugoNext
Copy link

Hello again everyone,

if I have understood correctly so far this is actually not a feature request but a bug.
Today I moved photos within the app inside the vault into a new folder. The files were immediately uploaded again automatically, so the files are now there twice.
Since my vault is getting bigger and bigger, this is really becoming a problem.

Should we change the label from feature-request to bug?
Maybe a developer will take care of it then?

I can also create a logfile if that helps?

Greetings

@pschultzendorff
Copy link

Hello again everyone,

if I have understood correctly so far this is actually not a feature request but a bug. Today I moved photos within the app inside the vault into a new folder. The files were immediately uploaded again automatically, so the files are now there twice. Since my vault is getting bigger and bigger, this is really becoming a problem.

Should we change the label from feature-request to bug? Maybe a developer will take care of it then?

I can also create a logfile if that helps?

Greetings

Hei,
going from the forum thread you linked, it certainly sounds that way. As I understand the issue, some apps constantly tell the cryptomator app that pictures are new, even though they were already uploaded. For me, this happened, when I marked pictures as favorites in the gallery (and in some other weird cases).

However, there was also some weird behavior where pictures were uploaded again after being marked as favorites, even though they were already in the auto upload folder in the vault (replacing the existing file). I couldn't reproduce this reliably, though.

The described bugs were simply fixed by deleting the cache, so thanks for the tip.

Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants