Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up files #17

Open
K-Ho opened this issue Oct 16, 2018 · 4 comments
Open

Clean up files #17

K-Ho opened this issue Oct 16, 2018 · 4 comments

Comments

@K-Ho
Copy link
Member

K-Ho commented Oct 16, 2018

Make lint pass with no warnings.

@K-Ho K-Ho self-assigned this Oct 16, 2018
@K-Ho K-Ho added this to In progress in Visualization 2.0 Oct 16, 2018
@K-Ho
Copy link
Member Author

K-Ho commented Oct 16, 2018

Going to need to replace componentWillReceiveProps with componentDidUpdate
EDIT: look into the getDerivedStateFromProps(props, state) lifecycle method.... or not..

@K-Ho K-Ho moved this from In progress to To do in Visualization 2.0 Oct 18, 2018
@K-Ho
Copy link
Member Author

K-Ho commented Nov 21, 2018

@K-Ho
Copy link
Member Author

K-Ho commented Nov 22, 2018

At times, props are passed many times down through components ("prop drilling"). We can fix this by either passing components as props by using the slot pattern or using the React’s Context API which can be used to pass props implicitly down to component tree.

@K-Ho K-Ho moved this from To do to In progress in Visualization 2.0 Nov 27, 2018
@K-Ho
Copy link
Member Author

K-Ho commented Nov 28, 2018

Going to need to replace componentWillReceiveProps with componentDidUpdate
EDIT: look into the getDerivedStateFromProps(props, state) lifecycle method.... or not..

"it is a bad idea to unconditionally copy props to state." (Source)

@K-Ho K-Ho moved this from In progress to Done in Visualization 2.0 Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant