Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Update section and timetable tables when course timings change" #174

Merged
merged 15 commits into from
Jun 1, 2024
Merged

"Update section and timetable tables when course timings change" #174

merged 15 commits into from
Jun 1, 2024

Conversation

kishan1735
Copy link
Contributor

No description provided.

soumitradev
soumitradev requested changes Feb 22, 2024
View reviewed changes
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small code-style related changes, overall code quality looks good. The main logic can be replaced by a lot of existing code/function calls.

One small note on your commits:
Your commit is:
feat: update timetable and sections table when there is change in course timings
It would ideally be:
feat: add update changed timetables endpoint

backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
@soumitradev soumitradev linked an issue Feb 24, 2024 that may be closed by this pull request
Add endpoint to change exam timings or class timings and edit existing timetable states #171
Closed
@soumitradev
Copy link
Member

I'll review this PR during this week most probably.

soumitradev
soumitradev requested changes May 22, 2024
View reviewed changes
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some small changes, LGTM. Would also be nice if we could wrap the whole thing in one transaction, like we do in addSection.ts

backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
backend/src/controllers/timetable/updateChangedTimetable.ts Outdated Show resolved Hide resolved
kishan1735 and others added 13 commits May 25, 2024 10:02
@kishan1735
fix: minor logic fixes
2d83639
@kishan1735
refactor: wrap queries in transaction
fca9315
@kishan1735
refactor: discard removeCourseExams function
f25ebbd
@soumitradev
fix: put updateChangedTimetable db queries in transaction for db cons…
6ff5629 
…istency
@soumitradev
fix: ensure updateChangedTimetables makes drafts private as well
14b0fb2
@soumitradev
perf: reduce timetables fetched by updateChangedTimetables, and adjus…
179583a 
…t updation logic to fit new query
@soumitradev
fix: remove sections on exam clash as well in updateChangedTimetable
5cc5ced
@soumitradev
fix: make updateChangedTimetables update timetable warnings as well
701cc7f
@soumitradev
fix: add date conversion in updateChangedTimetable to fix exam hours …
b6eb4cc 
…clash checking logic
@soumitradev
style: lint and organize imports using biome
1c68cf4
@soumitradev
docs: add comments to the updateChangedTimetable endpoint code
56dba28
@soumitradev
fix: remove redundant query from updateChangedTimetables
a426058
@soumitradev
fix: don't allow updateChangedTimetable to edit archived courses
c19ca17
@soumitradev soumitradev added this pull request to the merge queue Jun 1, 2024
Merged via the queue into master with commit 7fc428e Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumitradev soumitradev soumitradev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add endpoint to change exam timings or class timings and edit existing timetable states
2 participants
@kishan1735 @soumitradev