Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intgrated Akshat Oke's cms cred grabber extension #175

Merged
merged 17 commits into from
Jun 1, 2024
Merged

Intgrated Akshat Oke's cms cred grabber extension #175

merged 17 commits into from
Jun 1, 2024

Conversation

NamitBhutani
Copy link
Member

No description provided.

@soumitradev soumitradev linked an issue Feb 24, 2024 that may be closed by this pull request
Integrate Akshat Oke's CMS cred grabber extension for CMS Auto-Enrol #170
Closed
@NamitBhutani NamitBhutani force-pushed the integrate-akshat-oke-cms-extension branch from f5ecff5 to f70aa37 Compare February 24, 2024 18:21
soumitradev
soumitradev approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR overall, small changes required, mostly stylistic.

frontend/src/Cms.tsx Outdated Show resolved Hide resolved
frontend/src/Cms.tsx Outdated Show resolved Hide resolved
frontend/src/Cms.tsx Outdated Show resolved Hide resolved
frontend/src/Cms.tsx Show resolved Hide resolved
@soumitradev soumitradev self-requested a review May 22, 2024 08:18
soumitradev
soumitradev requested changes May 22, 2024
View reviewed changes
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, accidentally approved in my last review.

@soumitradev
Copy link
Member

Once this PR is merged, could you also refactor all the files to use a uniform naming convention for CMS? I've made a P2 issue for this in the release project.

@NamitBhutani
Copy link
Member Author

Once this PR is merged, could you also refactor all the files to use a uniform naming convention for CMS? I've made a P2 issue for this in the release project.

oki sure.

soumitradev
soumitradev approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small QoL changes, PR looks good otherwise.

frontend/package.json Outdated Show resolved Hide resolved
frontend/src/Cms.tsx Show resolved Hide resolved
frontend/src/Cms.tsx Outdated Show resolved Hide resolved
frontend/src/Cms.tsx Outdated Show resolved Hide resolved
frontend/src/Cms.tsx Outdated Show resolved Hide resolved
frontend/src/Cms.tsx Outdated Show resolved Hide resolved
soumitradev
soumitradev requested changes May 30, 2024
View reviewed changes
Copy link
Member

@soumitradev soumitradev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm getting old, I accidentally approved again.

@soumitradev
Copy link
Member

@NamitBhutani insane first PR, good shit

@soumitradev soumitradev added this pull request to the merge queue Jun 1, 2024
Merged via the queue into master with commit 6828b75 Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumitradev soumitradev soumitradev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Akshat Oke's CMS cred grabber extension for CMS Auto-Enrol
2 participants
@NamitBhutani @soumitradev