tests: AllOf failing immediately if fail-fast #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>
jbw976
approved these changes
May 10, 2024
| @@ -66,13 +66,18 @@ const DefaultPollInterval = time.Millisecond * 500 | |||
|
|
|||
| type onSuccessHandler func(o k8s.Object) | |||
|
|
|||
| // AllOf runs the supplied functions in order. | |||
| // AllOf runs the supplied functions in order. If a function fails the test and | |||
| // the environment is configured to fail fast (e2e-framework's -fail-fast flag) | |||
There was a problem hiding this comment.
looks like we are specifying the intent to fail fast with -test.failfast -fail-fast in the e2e step https://github.com/crossplane/crossplane/blob/master/.github/workflows/ci.yml#L306C47-L306C72 - were you able to also verify that the flag is making it down into this testing context correctly?
There was a problem hiding this comment.
yes, in our specific case, we do build our environment from flags, whether another user will pass down that correctly it's up to the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
e2e-framework has its own fail-fast flag, see docs.
This makes
funcs.AllOfaware of it, skipping the rest of the provided functions in fail-fast mode.Fixes #5672.
I have:
make reviewableto ensure this PR is ready for review.Added or updated unit tests.Added or updated e2e tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.