Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote claim server-side apply to beta #5656

Open
negz opened this issue May 8, 2024 · 2 comments
Open

Promote claim server-side apply to beta #5656

negz opened this issue May 8, 2024 · 2 comments
Labels
enhancement New feature or request feature-lifecycle
Milestone

Comments

@negz
Copy link
Member

negz commented May 8, 2024

What problem are you facing?

In Crossplane v1.15 we updated the claim reconciler to use server-side apply to create and update XRs. This is currently off by default, behind an alpha feature flag - #5313.

How could Crossplane help solve your problem?

I'm not aware of any issues with the implementation - we should flip it to beta.

@negz negz added enhancement New feature or request feature-lifecycle labels May 8, 2024
@negz negz added this to the v1.17 milestone May 8, 2024
@negz
Copy link
Member Author

negz commented May 9, 2024

Anecdotally, I'm seeing the E2E tests flake a lot for this one though. Something to address before beta:

TestPropagateFieldsRemovalToXRAfterUpgrade/TestPropagateFieldsRemovalToXRAfterUpgrade/FieldsRemovalPropagatedToXR

@negz
Copy link
Member Author

negz commented May 22, 2024

Something to be aware of: crossplane-contrib/provider-kubernetes#246 (comment)

It seems like in some cases SSA will bump the resource version of the applied object even if nothing changed. In theory this could cause a tight loop of reconciles:

  1. Claim controller uses SSA to apply XR
  2. API server bumps XR resource version even though nothing changed
  3. Claim controller notices updated XR, triggering a reconcile
  4. Back to step 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-lifecycle
Projects
Status: Alpha to Beta
Development

No branches or pull requests

1 participant