Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpkg login should support SSO #5625

Closed
Tracked by #3957
jbw976 opened this issue Apr 24, 2024 · 2 comments
Closed
Tracked by #3957

xpkg login should support SSO #5625

jbw976 opened this issue Apr 24, 2024 · 2 comments
Labels
bug Something isn't working crossplane-cli good first issue Good for newcomers user experience
Milestone

Comments

@jbw976
Copy link
Member

jbw976 commented Apr 24, 2024

What happened?

When using crossplane xpkg login to login to xpkg.upbound.io, it will fail if SSO is required for your organization:

❯ crossplane xpkg login
Username: jared@upbound.io
Password:
crossplane: error: failed to extract session: failed to read cookie format: {"message":"SSO required"}

This can currently be worked around by using a personal access token, e.g.:

❯ crossplane xpkg login --token=<token-redacted>
Login successful.

However, native support for SSO should be added so this command works with minimal friction.

How can we reproduce it?

Attempt to login as shown above when your organization has SSO enabled.

What environment did it happen in?

Crossplane version: v1.15.2

@Sanket-0510
Copy link

hey I wanted to contribute to this also created the org in the upbound. But I am not able to reproduce the error. The SSO feature is paid how can I setup a development environment for this to reproduce this error?

@jbw976
Copy link
Member Author

jbw976 commented May 14, 2024

Thanks for your interest in this issue @Sanket-0510!! 🙇‍♂️

After some more consideration of this scenario, it actually is a better fit for the up tool, since it is specifically related to the upbound marketplace's support of SSO. Users with that enabled on their marketplace accounts should use the up tool to push packages.

I'm going to close out this issue here, but there are plenty of other interesting issues to try out if you're interested! good first issue Good for newcomers

@jbw976 jbw976 closed this as completed May 14, 2024
@jbw976 jbw976 closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crossplane-cli good first issue Good for newcomers user experience
Projects
Status: Done
Development

No branches or pull requests

2 participants