Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy providers in a different namespace other than core #5634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deploy providers in a different namespace other than core #5634

wants to merge 1 commit into from
+2 −1

Conversation

padlar
Copy link
Contributor

@padlar padlar commented Apr 28, 2024 •
edited

Description of your changes

Use the namespace and service account of the core crossplane components to pull the ImagePullSecret.
Fixes #5576

I have:

Need help with this checklist? See the cheat sheet.

Followed the steps jotted down here #5449 (comment).

crossplane on  issue-5576 [$!?] via 🐹 v1.22.2
❯ k get providers
NAME                          INSTALLED   HEALTHY   PACKAGE                                              AGE
provider-aws-s3               True        True      xpkg.upbound.io/upbound/provider-aws-s3:v1.3.1       6m52s
upbound-provider-family-aws   True        True      xpkg.upbound.io/upbound/provider-family-aws:v1.4.0   14m

crossplane on  issue-5576 [$!?] via 🐹 v1.22.2
❯ k get pods -A
NAMESPACE              NAME                                                        READY   STATUS    RESTARTS   AGE
crossplane-providers   provider-aws-s3-80f883595f8c-67ccffcbc8-jxj2q               1/1     Running   0          6m50s
crossplane-providers   upbound-provider-family-aws-bac5d48bd353-869c456d7c-flpw9   1/1     Running   0          7m26s
crossplane-system      crossplane-6bd9f5f75d-r7l2g                                 1/1     Running   0          10m
crossplane-system      crossplane-rbac-manager-796fdb775d-szttc                    1/1     Running   0          14m
crossplane-system      upbound-provider-family-aws-bac5d48bd353-869c456d7c-sv522   1/1     Running   0          14m
kube-system            coredns-5d78c9869d-8nw7j                                    1/1     Running   0          43m

@padlar
Deploy providers in a different namespace other than core
4ee47d4 
Signed-off-by: Sunil Shivanand <padlar@live.com>
@padlar padlar requested review from turkenh and a team as code owners April 28, 2024 10:01
@padlar padlar requested a review from negz April 28, 2024 10:01
@negz
Copy link
Member

negz commented Apr 29, 2024

I'm not confident exactly what the requester of this feature wanted, so I'm holding off on the review until I hear back about #5576 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turkenh turkenh Awaiting requested review from turkenh turkenh is a code owner

@negz negz Awaiting requested review from negz negz is a code owner automatically assigned from crossplane/crossplane-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy a provider in a different namespace than the core
2 participants
@padlar @negz