Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies freeze the whole browser #22

Open
kuchikuu opened this issue Jan 8, 2024 · 3 comments
Open

Cookies freeze the whole browser #22

kuchikuu opened this issue Jan 8, 2024 · 3 comments

Comments

@kuchikuu
Copy link

kuchikuu commented Jan 8, 2024 •
edited

Hello,
Yesterday I had my Debian's dillo installed, and I was just running dillo-plus from the src/ directory.

Today, I apt remove dillo, and I installed dillo-plus with "make install".

After that, Dillo+ is using its own libraries, and apparently websites that use cookies freeze the browser.

I have even reverted my changes (that I pulled) and with commit 82f6faa as head, I get the following output:

user@debian:~/git/kuchikuu/dillo-plus/src$ ./dillo http://localhost:7777/setcookie_test.php
Domain: Default deny.
dillo_dns_init: Here we go! (threaded)
Loaded TLS certificates.
Enabling cookies as from cookiesrc...
Nav_open_url: new url='http://localhost:7777/setcookie_test.php'
Dns_server [0]: localhost is 127.0.0.1
Connecting to 127.0.0.1:7777
cookies.c: a_Dpi_send_blocking_cmd cmd = {<cmd='get_cookie' scheme='http' host='localhost' path='/setcookie_test.php' '>}
Dpi_check_dpid: check_st=1
Dpi_check_dpid: OK
Dpi_get_server_port: server_name = [cookies]
[<cmd='check_server' msg='cookies' '>]
Dpi_get_server_port: rply=<cmd='send_data' msg='5031' '>
Dpi_get_server_port: port_str=5031
Dpi_connect_socket: server=cookies port=5031

I did

sed -i 's/_MSG/MSG/g' cookies.c menu.cc IO/dpi.c

in the src/ directory before compiling to see the messages

The php page that freezes the browser is this:
(This is just an example to reproduce the issue. Any website that uses the cookies (with coockiesrc ALLOW) will freeze the browser. It's just that everything is disabled by default so we didn't see an issue. )

<?php
	setcookie("aaa","bbb", time()+2*24*60*60);
?>
<html>
<body>
<?php
	echo "Cookie: " . $_COOKIE["aaa"];
	echo "<br><br>";
	echo "All cookies: " . json_encode($_COOKIE);

?>
</body>
</html>```
@kuchikuu
Copy link
Author

kuchikuu commented Jan 8, 2024

The cookies are the a problem with 82f6faa (latest commit)

By using my changes ( 97a6452 ) I was able to disable cookies

  1. ./src/dillo
  2. Tools -> Disable cookies
  3. open my php script
  4. works
  5. Tools -> Enable cookies
  6. refresh
  7. freezes

Since it happens even on old commit, I don't suspect my changes to be the problem.

@kuchikuu
Copy link
Author

kuchikuu commented Jan 8, 2024

And just a word: When I was doing the cookie toggle yesterday, the cookies did not freeze the browser.
It started happening after I removed dillo from my computer and started using pure Dillo+. (after sudo make install)

@crossbowerbt
Copy link
Owner

The issue is strange indeed.
Can you test if with the new "Use cookies" option disabled (just merged in branch main) the issue is still present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crossbowerbt @kuchikuu