Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telnet: NaN garbage after pressing enter #213

Open
cherbert opened this issue Aug 29, 2022 · 1 comment
Open

Telnet: NaN garbage after pressing enter #213

cherbert opened this issue Aug 29, 2022 · 1 comment

Comments

@cherbert
Copy link

Hi, I am playing around with this library and trying to get it running within a Telnet server so I can have people connect via a terminal app.

When using the input example with autocomplete I get a lot NaN returns after pressing enter. I have made a little video showing. Initially I was using putty but that was all over the place and the input was jumping to the top of the page. I then looked at ZOC Terminal.

Is this library not really meant for remote connections? Do I need a better telnet library to run my server in Node? Do you recommend? I have also added a link to my code.

https://pastebin.com/KZ5zQmdn

ezgif.com-gif-maker.mp4
@cronvel
Copy link
Owner

cronvel commented Sep 8, 2022

@cherbert It should works, but there is something wrong with some escape sequences.
Unfortunately, it's hard to tell from the video alone...
I could probably fix the NaN thing, but if that appears, it means the escape sequence could not be parsed properly, which means it would break anyway.

To be honest, I can't even say which part of the stack is at fault: it could be your terminal MidnightBlue, or the Node.js telnet module you are using. Also I'm not very familiar with telnet nowadays, but I tested the lib through SSH, and it was OK.

@cronvel cronvel changed the title NaN garbage after pressing enter Telnet: NaN garbage after pressing enter Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants