Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to specify some Availability API request parameters using builder #134

Open
adionne-cc opened this issue Apr 4, 2024 · 0 comments
Open

No way to specify some Availability API request parameters using builder #134

adionne-cc opened this issue Apr 4, 2024 · 0 comments

Comments

@adionne-cc
Copy link

I was going about using this library to form and send requests to the Availability API using

cronofy-csharp/src/Cronofy/CronofyAccountClient.cs

Line 495 in 2673f54

public IEnumerable<AvailablePeriod> GetAvailability(AvailabilityRequest availabilityRequest)

I noticed however that there are some missing request parameters that the Availability API does accept in actual requests including:

  • response_format
  • max_results

I would like to see these added to the library. I can add them myself and put up a PR if that route makes sense. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adionne-cc