-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiple editions #1984
Comments
Is there support for "editions" on the Kodi side of things, @sammys? |
There are recent commits related to what looks like an overhaul of "versions". Haven't read any of the pull request threads nor code about it yet though. |
Update: there is a Plex bug that prevents PKC from receiving a comprehensive list of all editions. This is necessary to implement editions. Plex is working on it |
Great to hear. Thanks for the update! I've run into an issue most likely caused by the new versions feature in Kodi Omega that doesn't appear to have been posted about yet. It also might be possible to address before the Plex bug is fixed. I've tried the 3.8.4 beta with a new installation of Kodi Omega 21 beta 3 and it does a full initial sync of all Movies and TV Shows but the Kodi database does not end up containing any Movies yet does contain TV Shows. Pretty sure Kodi upgraded from pre-Omega will also not end up getting any Movies added to the Plex library after the upgrade. Do you want me to post a new issue regarding this or leave it as part of this issue since the versions implementation in PKC will obviously cover this issue. |
Use PKC beta 3.8.8 and you should be fine 😉 |
A bucket load of commits flew in under the radar hehe. Thanks to both of you, @croneter and @Spacetech! |
@croneter Tested a fresh installation of PKC beta 3.8.8 on Kodi 21 beta 3 on macOS and still no Movies shown after the initial sync. |
Works for anyone else... Make tripple sure that you're using the latest PKC beta 3.8.8. Then reset the Kodi database again. |
3.8.8 confirmed & database reset but PKC settings not reset. Still no Movies. Might be worth mentioning that I did click on Ok when it told me it's going to restart Kodi. I waited around 30 seconds then exited and started it again. Did a second round and, this time, also removed PKC settings. Waited 5 minutes and it still didn't restart itself though I didn't monitor it. Restarted, synced and no Movies. Deleted the Kodi data directory in my home directory using the shell and reinstalled everything from scratch. That worked. Guess something in the Kodi data directory was borking everything. |
Please open a new issue for that, @sammys, and share your entire DEBUG log file of the initial PKC sync. See https://github.com/croneter/PlexKodiConnect/wiki/How-to-Report-A-Bug |
@croneter If you're sure it's a valid use case I'll try to recreate it and post a new issue. It did arise from using a fresh installation of Kodi and a PKC version that doesn't have proper support for Omega (3.8.4) thus creating a "fictitious" database state. If you confirm you want it I'll use my development Plex library for it instead. |
A similar issue was posted as #1867 however the response covered versions and not editions. Editions are displayed by Plex as separate entities rather than being a single entity that versions are. Documentation by Plex
Using the default and Arctic Zephyr - Reloaded skins there doesn't appear to be any visible tagging of editions so I figured I ought to bring this up. Information of the entity does display the filename and that's what I've had to use to choose what to play.
Is there any existing support for displaying editions that I have overlooked? If not and displaying edition tags is possible somehow in Kodi I'm happy to scratch up a PR. If a PR is desired some advice/guidance is very welcome as I don't know the innards of Kodi yet!
The text was updated successfully, but these errors were encountered: