Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some maintenance updates missing from mu_dataset.json #390

Open
adamjanovsky opened this issue Feb 9, 2024 · 0 comments
Open

Some maintenance updates missing from mu_dataset.json #390

adamjanovsky opened this issue Feb 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@adamjanovsky
Copy link
Collaborator

Describe the bug

Maintenance updates for which either st_link or report_link does not exist are not properly processed by our pipeline. While they are scraped and recorded in the cert.maintenance_updates variable and displayed on Web, they are not further fetched into CCDatasetMaintenanceUpdates object.

This is due to the fact that the members of CCDatasetMaintenanceUpdates constitute a valid CCCertificate for which both st_link and report_link must be of type str. But this is not the case when either is missing, and so the following method disregards them:

def get_updates_from_cc_cert(cls, cert: CCCertificate) -> list[CCMaintenanceUpdate]:

@adamjanovsky adamjanovsky added the bug Something isn't working label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant