Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspect statefulness of stream ciphers' encrypt_bytes #79

Open
Bender250 opened this issue Jun 6, 2018 · 0 comments
Open

Inspect statefulness of stream ciphers' encrypt_bytes #79

Bender250 opened this issue Jun 6, 2018 · 0 comments
Labels
bug intermediate This issue should not take for more than few hours to skilled developer
Projects
CryptoStreams 3

Comments

@Bender250
Copy link
Collaborator

I added a test for generating ciphertext in byte-by-byte manner and found bugs in 6 functions.

[ FAILED ] 5 tests, listed below:
[ FAILED ] chacha.test_vectors
[ FAILED ] hermes.test_vectors
[ FAILED ] lex.test_vectors
[ FAILED ] salsa20.test_vectors
[ FAILED ] trivium.test_vectors
Fubuki fails even with segmentation fault.

I suggest to inspire from implementation in crypto-libraries. The easiest possible fix is to generate keystream into a buffer. However, it is still a task to inspect, if some other variable's state is not discarded by end of function. (Please, C++, give us yield keyword and generators).
@Bender250 Bender250 added the bug label Jun 6, 2018
@Bender250 Bender250 added this to ToDo in CryptoStreams 3 Aug 13, 2018
@Bender250 Bender250 added the intermediate This issue should not take for more than few hours to skilled developer label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug intermediate This issue should not take for more than few hours to skilled developer
Projects
CryptoStreams 3
  
ToDo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bender250