Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shave challenge clarification: which file should we be looking at? #560

Open
JoshuaKGoldberg opened this issue Aug 13, 2023 · 2 comments
Open

Comments

@JoshuaKGoldberg
Copy link

I love the idea of the "The Great Shave Off". Awesome. ⚡

But - just to be clear, which file should we be comparing? I would intuit dist/goober.modern.js because that's the default . export?

@cristianbote
Copy link
Owner

Hey @JoshuaKGoldberg!

Appreciate your shoutout! I love it too! 😄 That's a good point and in the past the way I've been referring to it was either file it is fine, and if the shave is spanning across multiple outputs the largest shave would be the one rewarded.

For example if you shave off -4B from .modern.js and -1B from .umd.js you would get $4!

Hope that clarifies it. Do you feel like this short explanation should be there on the page? 🤔

@JoshuaKGoldberg
Copy link
Author

Do you feel like this short explanation should be there on the page?

Either on the page or somewhere in the docs would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants