Error Handling Anti-Pattern

[CodeMan99]

I see that you are actively refactoring for various reasons. You should consider changing the error handling as well. In a few places you have something like the following.

try {
   if (err) {
      return callback(err);
   }
   // more stuff
} catch (e) {
   callback(e);
}

The usage of the callback inside of your try-catch is bad, especially in streams. That callback quite often synchronously calls the emit method. The emit method will also intentionally re-throw errors if there are no handlers. This is done because crashing is better than silently swallowing errors.

Alex Early explains this well: caolan/async#1458 (comment)

For most of your cases I suggest something like the following.

if (err) {
   return callback(new PluginError(PLUGIN_NAME, err));
}

var e, result;

try {
   result = processSomething();
} catch (err) {
   e = new PluginError(PLUGIN_NAME, err);
}

callback(e, result);

[crissdev]

Thanks @CodeMan99