Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addEditedAlleles() fails when the guide sequence is not editable #33

Closed
RussBainer opened this issue Apr 15, 2024 · 3 comments
Closed

Comments

@RussBainer
Copy link

Hi JP and Team, really enjoying this set of tools.

I've run into an error from the addEditingWeights() function that occurs when the targeted sequence doesn't have any nucleotides with values greater than zero in the base editor weight matrix.

I'm not sure how you'd want to address circumstances like this in terms of the functionality of the code, so I thought I'd raise it as an issue instead of a PR. I think you can resolve it on line 220 of addEditedAlleles.R by checking length(nNucs) > 0.
For example:

> crisprDesign:::.getExtendedSequences(gs, start = editingWindow[1], 
+                                      end = editingWindow[2])
spacer_1160 
   "GGGTGGTTGGGGT" 
> addEditedAlleles(gs, baseEditor = abe, txTable = txtable, editingWindow = win)
[addEditedAlleles] Obtaining edited alleles at each gRNA target site.
Error in -out$score : invalid argument to unary operator
@Jfortin1
Copy link
Member

Hi @RussBainer, taking a look at it right now

@Jfortin1
Copy link
Member

Pushed a fix; let me know if that works

@RussBainer
Copy link
Author

Sorry @Jfortin1 ! I just realized that my github notifications were going to my old work email.

This looks like a good fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants