Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth won't work for binary passwords containing zero byte characters #263

Open
balgillo opened this issue Sep 12, 2022 · 0 comments
Open

Comments

@balgillo
Copy link

https://github.com/creytiv/re/blob/master/include/re_sip.h#L239:

typedef int(sip_auth_h)(char **username, char **password, const char *realm,
			void *arg);

This won't work for a password containing a zero byte character, because that will be misinterpreted as the string terminator. The callback signature would need to be changed so that the callback function can provide the length of the password, either via a struct that includes a length such as struct mbuf, or via a separate out parameter.

Binary passwords are needed for AKAv1, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant