Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve zsh shell completion #361

Open
darix opened this issue Apr 8, 2024 · 1 comment
Open

improve zsh shell completion #361

darix opened this issue Apr 8, 2024 · 1 comment
Assignees

Comments

@darix
Copy link

darix commented Apr 8, 2024

currently the generated zsh shell completion then calls the binary again to generate out the bash port. wouldnt it be easier to do something like this pseudocode as part of the golang code

bash_preamble + shared_completion_code + bash_trailer

zsh_preamble + shared_completion_code + zsh_trailer 

that way the zsh code completion wouldnt need to exec + eval again to include the common code.

@jkellerer
Copy link
Collaborator

jkellerer commented Apr 8, 2024

To be honest, the zsh completion is a hack at the moment. After the next release, I have the plan to overhaul the completion code as we no longer depend on restic to complete restic commands. And also powershell should get support.

When this is implemented, zsh (which is also my main shell) will get direct support.

@jkellerer jkellerer self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants