Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retention flag after-backup not defaults to true #301

Open
treac1e opened this issue Jan 26, 2024 · 1 comment
Open

Retention flag after-backup not defaults to true #301

treac1e opened this issue Jan 26, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@treac1e
Copy link

treac1e commented Jan 26, 2024

In the reference for Section profile.retention for the flag after-backup it reads:

Apply retention after the backup command succeeded. Defaults to true if any “keep-*” flag is set and “before-backup” is unset

But this is not working. I had to explicitly set after-backup = true

  [default.retention]
    after-backup = true
    keep-daily = 30
    prune = true

Withou setting after-backup = true the retention profile was not executed. So the flag after-backup not defaults to true.

I don't know if this is a mistake in the reference or it is a bug in the code. Maybe someone could check the issue.

Thank you!
Bruno

@creativeprojects
Copy link
Owner

Sorry for the late reply...

I double checked, and actually it is working, but for configuration format v2 only.
We haven't introduced it in configuration v1 as it is a potentially breaking change.

Thanks for pointing it out though, I'll update the documentation 😉

@creativeprojects creativeprojects added the documentation Improvements or additions to documentation label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants