Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve height of Aside container (or children) #13

Open
TimidRobot opened this issue Apr 2, 2024 · 2 comments
Open

[Feature] Improve height of Aside container (or children) #13

TimidRobot opened this issue Apr 2, 2024 · 2 comments
Labels
help wanted Open to participation from the community 🏷 status: label work required Needs proper labelling before it can be worked on
Projects

Comments

@TimidRobot
Copy link
Member

TimidRobot commented Apr 2, 2024

Problem

First documented by @ShivamAhir in:

The side bar (aside) currently extends down the entire length of the page, resulting in poor visual appearance.

Description

The solution made in creativecommons/cc-legal-tools-app#427 and proposed in creativecommons/cc-legal-tools-app#428 should be generalized and adapted to the Vocabulary design system for use in a variety of projects

Related:

@TimidRobot TimidRobot added the help wanted Open to participation from the community label Apr 2, 2024
@keshav861
Copy link

keshav861 commented Apr 2, 2024

i have a doubt the base.css has already been change the the changes to aside container is made should be shown as base.css is only one which is connected to all the html pages then the changes should be shown

one more doubt when i inspect the html page the the changes i made to the base.css is not showing too. on the server side but on the github repo it has been changed already....??

@TimidRobot
Copy link
Member Author

@possumbilities possumbilities transferred this issue from creativecommons/index-prototype Apr 24, 2024
@cc-open-source-bot cc-open-source-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open to participation from the community 🏷 status: label work required Needs proper labelling before it can be worked on
Projects
Backlog
  
Vocabulary
Development

No branches or pull requests

3 participants