Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbify Compositor --> Composite #427

Closed
mpu-creare opened this issue Oct 20, 2020 · 5 comments
Closed

Verbify Compositor --> Composite #427

mpu-creare opened this issue Oct 20, 2020 · 5 comments
Assignees
@mpu-creare
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
Priorities

Comments

@mpu-creare
Copy link
Contributor

mpu-creare commented Oct 20, 2020 •
edited by jmilloy

Mark for depreciation, in version 3.0 (for removal in version 4.0).

Noun Verb
Compositor Composite
Reprojector Reproject
Interpolator Interpolate
CoordinatesModifier ModifyCoordinates
CoordinatesExpander ExpandCoordinates
CoordinatesSelector SelectCoordinates
Combiner Combine
Convolution Convolve
ReductionOperator Reduce

(current name in bold)
@mpu-creare mpu-creare added the enhancement New feature or request label Oct 20, 2020
@mpu-creare mpu-creare self-assigned this Oct 20, 2020
@mpu-creare mpu-creare added this to To do in Priorities via automation Oct 20, 2020
@mpu-creare mpu-creare mentioned this issue Oct 20, 2020
Merged
@jmilloy
Copy link
Collaborator

jmilloy commented Dec 7, 2020 •
edited

The essense of this issue is to be consistent. I know I originally proposed the verb, but now I've changed my mind. There is some consensus that class names should not be verbs: the methods are the verbs.

@jmilloy
Copy link
Collaborator

jmilloy commented Dec 7, 2020

See, for example, pyproj transformers:

transformer = pyproj.Transformer(...)
newcoords = transformer.transform(...)

@mpu-creare
Copy link
Contributor Author

Wow! Went the other way. I didn't expect that., but yes, that makes sense. Ok. Let's plan to go with Nouns.

I like Expander

@jmilloy jmilloy added the wontfix This will not be worked on label Dec 16, 2020
@jmilloy
Copy link
Collaborator

jmilloy commented Dec 16, 2020

The API naming and structure needs a full audit.

@jmilloy
Copy link
Collaborator

jmilloy commented May 28, 2021

I suspect we won't make any significant changes at this point, but in any case this has been superseded by #439

@jmilloy jmilloy closed this as completed May 28, 2021
Priorities automation moved this from To do to Done May 28, 2021
@mpu-creare mpu-creare mentioned this issue Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpu-creare mpu-creare

Labels
enhancement New feature or request wontfix This will not be worked on
Projects
Priorities
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmilloy @mpu-creare